westonpace commented on pull request #9632: URL: https://github.com/apache/arrow/pull/9632#issuecomment-790845365
@pitrou Looks good to me. I wonder if we will even need to use AWS' async mode? It seems that calling into S3 this way is pretty much equivalent to overriding their executor with our own. Callers will have to take care to know that these futures will complete on the IOContext and transfer them off quickly but looking at it now I agree that the transfer doesn't belong in here. Looks great. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org