xinlifoobar commented on PR #6180: URL: https://github.com/apache/arrow-rs/pull/6180#issuecomment-2267488827
> Thank you @xinlifoobar -- I think this code does what the ticket described > > However, I think this implementation's speed could be improved significantly. > > Any chance you are also willing to add a benchmark in this (or another PR)? Perhaps in > > https://github.com/apache/arrow-rs/blob/01407f4824fa4eb656398558183c7cd01537246e/arrow/benches/cast_kernels.rs#L153 > > I think important benchmarks would be: > > Utf8Array --> StringViewArray Utf8Array --> BinaryViewArray > > BinaryViewArray --> Utf8Array StringViewArray --> Utf8Array > > StringViewArray --> BinaryViewArray BinaryViewArray --> StringViewArray Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
