eramitmittal commented on code in PR #43551:
URL: https://github.com/apache/arrow/pull/43551#discussion_r1703559377
##########
java/flight/flight-integration-tests/src/main/java/org/apache/arrow/flight/integration/tests/FlightSqlScenarioProducer.java:
##########
@@ -577,35 +646,12 @@ public Runnable acceptPutPreparedStatementQuery(
@Override
public FlightInfo getFlightInfoSqlInfo(
FlightSql.CommandGetSqlInfo request, CallContext context,
FlightDescriptor descriptor) {
- if (request.getInfoCount() == 2) {
Review Comment:
validateMetadataRetrieval method in FlightSqlScenario class has been
enhanced to check expected results. Hence test coverage is not lost.
`
validate(
FlightSqlProducer.Schemas.GET_SQL_INFO_SCHEMA,
sqlClient.getSqlInfo(
new FlightSql.SqlInfo[] {
FlightSql.SqlInfo.FLIGHT_SQL_SERVER_NAME,
FlightSql.SqlInfo.FLIGHT_SQL_SERVER_READ_ONLY
},
options),
sqlClient,
s -> {
Map<Integer, Object> infoValues = readSqlInfoStream(s);
IntegrationAssertions.assertEquals(
Boolean.FALSE,
infoValues.get(FlightSql.SqlInfo.FLIGHT_SQL_SERVER_READ_ONLY_VALUE));
IntegrationAssertions.assertEquals(
FlightSqlScenarioProducer.SERVER_NAME,
infoValues.get(FlightSql.SqlInfo.FLIGHT_SQL_SERVER_NAME_VALUE));
});
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
