tscottcoombes1 commented on code in PR #43555:
URL: https://github.com/apache/arrow/pull/43555#discussion_r1703991273
##########
go/arrow/util/protobuf_reflect.go:
##########
@@ -237,12 +234,10 @@ func (pfr *ProtobufFieldReflection) asList()
protobufListReflection {
}
func (plr protobufListReflection) getDataType() arrow.DataType {
- for li := range plr.generateListItems() {
- return arrow.ListOf(li.getDataType())
- }
pfr := ProtobufFieldReflection{
descriptor: plr.descriptor,
schemaOptions: plr.schemaOptions,
+ isListItem: true,
Review Comment:
this is the key change for lists, protoreflect doesn't come with a get
underlying type function instead the isList is set to true, so on the 2nd pass
to get the data type we override the isList with isListItem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
