pitrou commented on code in PR #41904:
URL: https://github.com/apache/arrow/pull/41904#discussion_r1704169755
##########
python/pyarrow/tests/test_types.py:
##########
@@ -1261,19 +1264,22 @@ def test_field_modified_copies():
assert f0.equals(f0_)
[email protected]
def test_is_integer_value():
assert pa.types.is_integer_value(1)
assert pa.types.is_integer_value(np.int64(1))
assert not pa.types.is_integer_value('1')
Review Comment:
Perhaps we should instead just guard the corresponding assertion?
```suggestion
@pytest.mark.numpy
def test_is_integer_value():
assert pa.types.is_integer_value(1)
if np is not None:
assert pa.types.is_integer_value(np.int64(1))
assert not pa.types.is_integer_value('1')
```
##########
python/pyarrow/tests/test_types.py:
##########
@@ -1261,19 +1264,22 @@ def test_field_modified_copies():
assert f0.equals(f0_)
[email protected]
def test_is_integer_value():
assert pa.types.is_integer_value(1)
assert pa.types.is_integer_value(np.int64(1))
assert not pa.types.is_integer_value('1')
Review Comment:
Perhaps we should instead just guard the corresponding assertion?
```suggestion
def test_is_integer_value():
assert pa.types.is_integer_value(1)
if np is not None:
assert pa.types.is_integer_value(np.int64(1))
assert not pa.types.is_integer_value('1')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
