WillAyd commented on code in PR #574:
URL: https://github.com/apache/arrow-nanoarrow/pull/574#discussion_r1704453047
##########
meson.build:
##########
@@ -148,50 +164,28 @@ if get_option('tests')
arrow_dep = dependency('arrow')
gtest_dep = dependency('gtest_main')
gmock_dep = dependency('gmock')
- nlohmann_json_dep = dependency('nlohmann_json')
- nanoarrow_tests = {
- 'utils': {
- 'deps': [arrow_dep, gtest_dep, gmock_dep, nlohmann_json_dep],
- },
- 'buffer': {
- 'deps': [arrow_dep, gtest_dep],
- },
- 'array': {
- 'deps': [arrow_dep, gtest_dep, gmock_dep],
- },
- 'schema': {
- 'deps': [arrow_dep, gtest_dep],
- },
- 'array-stream': {
- 'deps': [arrow_dep, gtest_dep, gmock_dep],
- },
- 'nanoarrow-hpp': {
- 'deps': [arrow_dep, gtest_dep, gmock_dep, nlohmann_json_dep],
- },
- }
-
- foreach name, config : nanoarrow_tests
+ nanoarrow_tests = ['utils', 'buffer', 'array', 'schema', 'array-stream',
'nanoarrow-hpp']
+
+ foreach name : nanoarrow_tests
exc = executable(
name + '-test',
sources: 'src/nanoarrow/common/' + name.replace('-', '_') + '_test.cc',
- link_with: nanoarrow_lib,
include_directories: incdir,
- dependencies: config['deps'],
+ dependencies: [nanoarrow_testing_dep, nanoarrow_dep, arrow_dep,
gtest_dep, gmock_dep],
Review Comment:
Not sure if it matters too much, but `nanoarrow_dep` is duplicative here,
since `nanoarrow_testing_dep` already includes that in its `declare_dependency`
declaration
##########
meson.options:
##########
@@ -25,6 +25,7 @@ option('integration_tests', type: 'boolean',
option('namespace', type: 'string',
description: 'A prefix for exported symbols')
option('device', type: 'boolean', description: 'Build device libraries',
value: false)
+option('testing', type: 'boolean', description: 'Build testing libraries',
value: false)
Review Comment:
Is there any advantage to adding this as a new build option versus just
having it tied to the existing `tests` option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
