mapleFU commented on code in PR #6159:
URL: https://github.com/apache/arrow-rs/pull/6159#discussion_r1704834483
##########
parquet/src/encodings/encoding/byte_stream_split_encoder.rs:
##########
@@ -53,13 +53,28 @@ fn split_streams_const<const TYPE_SIZE: usize>(src: &[u8],
dst: &mut [u8]) {
}
}
+// Like above, but type_size is not known at compile time.
+fn split_streams_variable(src: &[u8], dst: &mut [u8], type_size: usize) {
+ const BLOCK_SIZE: usize = 4;
+ let stride = src.len() / type_size;
+ for j in (0..type_size).step_by(BLOCK_SIZE) {
+ let jrange = cmp::min(BLOCK_SIZE, type_size - j);
+ for i in 0..stride {
+ for jj in 0..jrange {
+ dst[i + (j + jj) * stride] = src[i * type_size + j + jj];
+ }
+ }
+ }
+}
+
impl<T: DataType> Encoder<T> for ByteStreamSplitEncoder<T> {
fn put(&mut self, values: &[T::T]) -> Result<()> {
self.buffer
.extend(<T as DataType>::T::slice_as_bytes(values));
+
ensure_phys_ty!(
- Type::FLOAT | Type::DOUBLE,
- "ByteStreamSplitEncoder only supports FloatType or DoubleType"
+ Type::FLOAT | Type::DOUBLE | Type::INT32 | Type::INT64,
+ "ByteStreamSplitEncoder does not support Int96, Boolean, or
ByteArray types"
Review Comment:
How can ByteArray Type be support here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
