emkornfield commented on code in PR #40594:
URL: https://github.com/apache/arrow/pull/40594#discussion_r1704927636
##########
cpp/src/parquet/page_index.cc:
##########
@@ -636,6 +691,19 @@ class OffsetIndexBuilderImpl final : public
OffsetIndexBuilder {
page_location.__set_offset(page_location.offset + final_position);
}
}
+
+ /// Finalize unencoded_byte_array_data_bytes and make sure page sizes
match.
+ if (offset_index_.page_locations.size() ==
+ offset_index_.unencoded_byte_array_data_bytes.size()) {
+ offset_index_.__isset.unencoded_byte_array_data_bytes = true;
Review Comment:
The check above is short hand if anything isn't provided? we only expect
two states they always match or they never match once page is added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
