jorisvandenbossche commented on PR #43602: URL: https://github.com/apache/arrow/pull/43602#issuecomment-2273363452
@tlm365 thanks for the PR! > I choose use `importlib.resources()` (1) instead of `numpy.get_include()` (2) because: > (2) need `import numpy`, then some current release test will fail (eg: [ci/scripts/release_test.sh](https://github.com/apache/arrow/actions/runs/10281234832/job/28450333148)), we need to add `numpy` as a dependency for `requirements-test` While using `numpy.get_include()` might indeed require some updates elsewhere, I think we should still try to take that route (it's the official public way provided by numpy to get that information, without needing to rely on internal details, e.g. that it is in `core/include`). It might also be that you could move the `import numpy` inline to where it would be used, and then certain invocations of setup.py might still work without numpy installed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
