gstvg opened a new pull request, #6209:
URL: https://github.com/apache/arrow-rs/pull/6209

   # Which issue does this PR close?
   
   Closes #6206.
   
   # What changes are included in this PR?
   
   At #5873, I naively called `filter_primitive` instead of `filter` to avoid 
arcing and downcasting, but this bypass the [check for when all values match 
the 
predicate](https://github.com/apache/arrow-rs/blob/49840ec0f110da5e9a21ce97affd32313d0b720f/arrow-select/src/filter.rs#L321),
 which `filter_primitive` expects to happen, leading `unreachable!()` to be 
[hit](https://github.com/apache/arrow-rs/blob/49840ec0f110da5e9a21ce97affd32313d0b720f/arrow-select/src/filter.rs#L548)
   
   This PR calls `filter` instead of `filter_primitive`, and removes the added 
`pub(crate)` from `filter_primitive` to avoid future misuse.
   
   # Are there any user-facing changes?
   
   No
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to