xinlifoobar commented on issue #6058: URL: https://github.com/apache/arrow-rs/issues/6058#issuecomment-2275269855
Hi @alamb and @XiangpengHao, I have some observations for this issue. The uf8 validation only happens when row.config.validate_utf8 is true. https://github.com/apache/arrow-rs/blob/49840ec0f110da5e9a21ce97affd32313d0b720f/arrow-row/src/lib.rs#L1302C1-L1303C1 The validate_utf8 is only set to true when initialized from a RowParser https://github.com/apache/arrow-rs/blob/49840ec0f110da5e9a21ce97affd32313d0b720f/arrow-row/src/lib.rs#L781-L788 I find the only usage of `RowParse is here` in `RowConverter` and test, did this mean the validate_utf8 will never set to true in the current implementation of `arrow-rs` and we would have the additional validation? https://github.com/apache/arrow-rs/blob/49840ec0f110da5e9a21ce97affd32313d0b720f/arrow-row/src/lib.rs#L759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
