0x26res commented on PR #43609: URL: https://github.com/apache/arrow/pull/43609#issuecomment-2275310890
> Thanks, looks good! > > One thing I am wondering is how specific we should be with those checks in general. Before 17.0 (before #40645), any iterable would have worked. With this change it is still only list and tuple. (I don't think we are very consistent about this throughout the code base) I agree. I was having a look there are a few user/API function where we look for list and we could look out for iterable. But it's not that simple. A `str` is sequence, so is a `dict`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
