tustvold commented on code in PR #6187: URL: https://github.com/apache/arrow-rs/pull/6187#discussion_r1709230379
########## parquet/src/arrow/arrow_reader/statistics.rs: ########## @@ -1052,10 +1046,7 @@ fn max_statistics<'a, I: Iterator<Item = Option<&'a ParquetStatistics>>>( /// Extracts the min statistics from an iterator /// of parquet page [`Index`]'es to an [`ArrayRef`] -pub(crate) fn min_page_statistics<'a, I>( - data_type: Option<&DataType>, - iterator: I, -) -> Result<ArrayRef> +pub(crate) fn min_page_statistics<'a, I>(data_type: &DataType, iterator: I) -> Result<ArrayRef> Review Comment: This is just a drive-by observation that this will generate a fair amount of code for every iterator, it might be worth just paying the cost of just forcing `&[ParquetStatistics]` or similar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
