rok commented on issue #43614:
URL: https://github.com/apache/arrow/issues/43614#issuecomment-2275928995

   > In theory nothing in the spec says that you can only use it for numerical 
data types (although that is of course the typical use case)
   
   Yes, but we can't really express string tensor with `FixedShapeTensorArray`. 
Perhaps we could with `VariableShapeTensorArray` where the last dimension is 
length of the string? :)
   
   > From a user point of view, I don't directly see a reason to not support 
this conversion. The practical reason it no longer works is because of an 
implementation change in https://github.com/apache/arrow/pull/37533 where we 
moved this conversion to a numpy array to the C++ level through first 
converting to a Tensor (i.e. the to_numpy_ndarray() method now just calls 
self.to_tensor().to_numpy()), and we do only support numerical data types for a 
Tensor.
   
   That's a good point. We can reintroduce the old path for types that can't be 
converted into Tensors (I suppose that'll only string anyway).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to