HaochengLIU commented on PR #41998: URL: https://github.com/apache/arrow/pull/41998#issuecomment-2276272132
Hi folks, thanks for reviewing and I've addressed most of the comments. Referring to the non-backward compatible `check_directory_existence_before_creation` flag, IMHO refactoring fs___S3FileSystem__create (and the other FileSystem create methods, for consistency) sounds should be a seperate PR Though if [arrow/r/src/extension-impl.cpp](https://github.com/apache/arrow/blob/c69c1d80eb27022c1b3f91fbbc7979f8293c9e50/r/src/extension-impl.cpp#L103) will not work per @nealrichardson , I can try to tackle the refactor first once I'm back from vacation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
