chloro-pn commented on PR #6178:
URL: https://github.com/apache/arrow-rs/pull/6178#issuecomment-2276862007
The baseline is `extend_from_slice` version.
According to the benchmark results, there is almost no difference in
performance between these two methods
```
filter fsb with value length 5 (kept 1/2)
time: [119.79 µs 119.95 µs 120.16 µs]
change: [-1.0017% +0.9824% +3.0183%] (p = 0.35 >
0.05)
No change in performance detected.
Found 13 outliers among 100 measurements (13.00%)
3 (3.00%) high mild
10 (10.00%) high severe
filter fsb with value length 5 high selectivity (kept 1023/1024)
time: [20.973 µs 21.159 µs 21.352 µs]
change: [+1.7384% +2.8273% +3.8921%] (p = 0.00 <
0.05)
Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild
filter fsb with value length 5 low selectivity (kept 1/1024)
time: [1.6726 µs 1.6808 µs 1.6892 µs]
change: [-12.122% -11.630% -11.143%] (p = 0.00 <
0.05)
Performance has improved.
filter context fsb with value length 5 (kept 1/2)
time: [22.079 µs 22.143 µs 22.247 µs]
change: [-0.1067% +0.2270% +0.5189%] (p = 0.16 >
0.05)
No change in performance detected.
Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) high mild
4 (4.00%) high severe
filter context fsb with value length 5 high selectivity (kept 1023/1024)
time: [22.071 µs 22.099 µs 22.152 µs]
change: [-0.1885% +0.1895% +0.5296%] (p = 0.34 >
0.05)
No change in performance detected.
Found 10 outliers among 100 measurements (10.00%)
4 (4.00%) high mild
6 (6.00%) high severe
filter context fsb with value length 5 low selectivity (kept 1/1024)
time: [22.062 µs 22.095 µs 22.143 µs]
change: [+0.0099% +0.1751% +0.3568%] (p = 0.04 <
0.05)
Change within noise threshold.
Found 9 outliers among 100 measurements (9.00%)
2 (2.00%) high mild
7 (7.00%) high severe
filter fsb with value length 20 (kept 1/2)
time: [134.22 µs 134.38 µs 134.53 µs]
change: [+4.3318% +4.6516% +4.9943%] (p = 0.00 <
0.05)
Performance has regressed.
Found 13 outliers among 100 measurements (13.00%)
5 (5.00%) low mild
5 (5.00%) high mild
3 (3.00%) high severe
filter fsb with value length 20 high selectivity (kept 1023/1024)
time: [271.86 µs 273.74 µs 275.71 µs]
change: [+5.3890% +7.3050% +9.1749%] (p = 0.00 <
0.05)
Performance has regressed.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
filter fsb with value length 20 low selectivity (kept 1/1024)
time: [1.6427 µs 1.6509 µs 1.6592 µs]
change: [-11.179% -10.468% -9.7402%] (p = 0.00 <
0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild
filter context fsb with value length 20 (kept 1/2)
time: [22.169 µs 22.255 µs 22.355 µs]
change: [-3.0221% -2.3515% -1.6009%] (p = 0.00 <
0.05)
Performance has improved.
Found 13 outliers among 100 measurements (13.00%)
3 (3.00%) high mild
10 (10.00%) high severe
filter context fsb with value length 20 high selectivity (kept 1023/1024)
time: [22.092 µs 22.294 µs 22.540 µs]
change: [+0.0301% +0.5035% +1.0283%] (p = 0.06 >
0.05)
No change in performance detected.
Found 10 outliers among 100 measurements (10.00%)
3 (3.00%) high mild
7 (7.00%) high severe
filter context fsb with value length 20 low selectivity (kept 1/1024)
time: [22.078 µs 22.153 µs 22.278 µs]
change: [-0.9876% -0.0396% +0.7882%] (p = 0.93 >
0.05)
No change in performance detected.
Found 10 outliers among 100 measurements (10.00%)
6 (6.00%) high mild
4 (4.00%) high severe
filter fsb with value length 50 (kept 1/2)
time: [420.94 µs 432.61 µs 444.20 µs]
change: [+1.7582% +4.1423% +6.5138%] (p = 0.00 <
0.05)
Performance has regressed.
Found 11 outliers among 100 measurements (11.00%)
9 (9.00%) low mild
2 (2.00%) high mild
filter fsb with value length 50 high selectivity (kept 1023/1024)
time: [700.91 µs 713.64 µs 727.65 µs]
change: [-0.8821% +1.3435% +3.3318%] (p = 0.25 >
0.05)
No change in performance detected.
Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) high mild
4 (4.00%) high severe
filter fsb with value length 50 low selectivity (kept 1/1024)
time: [1.8066 µs 1.8227 µs 1.8416 µs]
change: [-10.498% -9.3662% -7.8719%] (p = 0.00 <
0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
2 (2.00%) high mild
3 (3.00%) high severe
filter context fsb with value length 50 (kept 1/2)
time: [22.234 µs 22.498 µs 22.830 µs]
change: [-1.1997% -0.0554% +0.9810%] (p = 0.92 >
0.05)
No change in performance detected.
Found 14 outliers among 100 measurements (14.00%)
3 (3.00%) high mild
11 (11.00%) high severe
filter context fsb with value length 50 high selectivity (kept 1023/1024)
time: [22.073 µs 22.094 µs 22.122 µs]
change: [-0.4814% -0.0013% +0.5338%] (p = 1.00 >
0.05)
No change in performance detected.
Found 13 outliers among 100 measurements (13.00%)
1 (1.00%) high mild
12 (12.00%) high severe
filter context fsb with value length 50 low selectivity (kept 1/1024)
time: [22.112 µs 22.232 µs 22.437 µs]
change: [-0.4878% -0.0770% +0.5095%] (p = 0.78 >
0.05)
No change in performance detected.
Found 10 outliers among 100 measurements (10.00%)
1 (1.00%) high mild
9 (9.00%) high severe
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
