zanmato1984 commented on code in PR #43389:
URL: https://github.com/apache/arrow/pull/43389#discussion_r1710755290
##########
cpp/src/arrow/acero/swiss_join.cc:
##########
@@ -593,7 +586,8 @@ void RowArrayMerge::CopyVaryingLength(RowTableImpl* target,
const RowTableImpl&
int64_t source_row_id = source_rows_permutation[i];
const uint64_t* source_row_ptr = reinterpret_cast<const uint64_t*>(
source.data(2) + source_offsets[source_row_id]);
- uint32_t length = source_offsets[source_row_id + 1] -
source_offsets[source_row_id];
+ int64_t length = source_offsets[source_row_id + 1] -
source_offsets[source_row_id];
+ DCHECK_LE(length, std::numeric_limits<uint32_t>::max());
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
