etseidl opened a new pull request, #6220:
URL: https://github.com/apache/arrow-rs/pull/6220

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
    
   Following up on 
https://github.com/apache/arrow-rs/pull/6159#discussion_r1702114084, this adds 
`set_from_bytes` to the private `ParquetValueType` trait. This avoids the need 
for downcasting for byte array types.
   
   # What changes are included in this PR?
   In addition to the above, it also changes the formatting in the encoding 
benchmark to distinguish between `FixedLenByteArray(2)` and 
`FixedLenByteArray(16)`. Without this critcmp overwrites the `FLBA(2)` results.
   
   # Are there any user-facing changes?
   
   No, changes are to private interfaces.
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to