crepererum commented on code in PR #6224:
URL: https://github.com/apache/arrow-rs/pull/6224#discussion_r1713608031
##########
arrow-array/src/types.rs:
##########
@@ -101,163 +101,165 @@ make_type!(
Int16Type,
i16,
DataType::Int16,
- "A signed 16-bit integer type."
+ "Signed 16-bit integer type."
);
make_type!(
Int32Type,
i32,
DataType::Int32,
- "A signed 32-bit integer type."
+ "Signed 32-bit integer type."
);
make_type!(
Int64Type,
i64,
DataType::Int64,
- "A signed 64-bit integer type."
+ "Signed 64-bit integer type."
);
make_type!(
UInt8Type,
u8,
DataType::UInt8,
- "An unsigned 8-bit integer type."
+ "Unsigned 8-bit integer type."
);
make_type!(
UInt16Type,
u16,
DataType::UInt16,
- "An unsigned 16-bit integer type."
+ "Unsigned 16-bit integer type."
);
make_type!(
UInt32Type,
u32,
DataType::UInt32,
- "An unsigned 32-bit integer type."
+ "Unsigned 32-bit integer type."
);
make_type!(
UInt64Type,
u64,
DataType::UInt64,
- "An unsigned 64-bit integer type."
+ "Unsigned 64-bit integer type."
);
make_type!(
Float16Type,
f16,
DataType::Float16,
- "A 16-bit floating point number type."
+ "16-bit floating point number type."
);
make_type!(
Float32Type,
f32,
DataType::Float32,
- "A 32-bit floating point number type."
+ "32-bit floating point number type."
);
make_type!(
Float64Type,
f64,
DataType::Float64,
- "A 64-bit floating point number type."
+ "64-bit floating point number type."
);
make_type!(
TimestampSecondType,
i64,
DataType::Timestamp(TimeUnit::Second, None),
- "A timestamp second type with an optional timezone."
+ "Timestamp second type with an optional timezone."
);
make_type!(
TimestampMillisecondType,
i64,
DataType::Timestamp(TimeUnit::Millisecond, None),
- "A timestamp millisecond type with an optional timezone."
+ "Timestamp millisecond type with an optional timezone."
);
make_type!(
TimestampMicrosecondType,
i64,
DataType::Timestamp(TimeUnit::Microsecond, None),
- "A timestamp microsecond type with an optional timezone."
+ "Timestamp microsecond type with an optional timezone."
);
make_type!(
TimestampNanosecondType,
i64,
DataType::Timestamp(TimeUnit::Nanosecond, None),
- "A timestamp nanosecond type with an optional timezone."
+ "Timestamp nanosecond type with an optional timezone."
);
make_type!(
Date32Type,
i32,
DataType::Date32,
- "A 32-bit date type representing the elapsed time since UNIX epoch in
days(32 bits)."
+ "32-bit date type: the elapsed time since UNIX epoch in days (32 bits)."
);
make_type!(
Date64Type,
i64,
DataType::Date64,
- "A 64-bit date type representing the elapsed time since UNIX epoch in
milliseconds(64 bits)."
+ "64-bit date type: the elapsed time since UNIX epoch in milliseconds (64
bits). \
+ Values must be divisible by `86_400_000`. \
+ See [DataType::Date64] for more details."
Review Comment:
I'm also not entirely sure if this newline handling is correct in markdown.
Might be that this is
```
foo
bar
baz
```
in markdown, which might result in a code block (depending on the parser).
Might be worth to double-check this locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
