jorisvandenbossche commented on code in PR #43539:
URL: https://github.com/apache/arrow/pull/43539#discussion_r1713907802
##########
ci/scripts/install_gcs_testbench.sh:
##########
@@ -38,11 +38,16 @@ esac
export PIP_BREAK_SYSTEM_PACKAGES=1
version=$1
+python_command="python${PYTHON:-3}"
if [[ "${version}" -eq "default" ]]; then
version="v0.39.0"
# Latests versions of Testbench require newer setuptools
${PYTHON:-python3} -m pip install --upgrade setuptools
fi
-${PYTHON:-python3} -m pip install \
- "https://github.com/googleapis/storage-testbench/archive/${version}.tar.gz";
+# This script is run with PYTHON undefined in some places,
+# but those only use older pythons.
+if [[ -z "${PYTHON}" || "${PYTHON}" != "3.13" ]]; then
Review Comment:
To make this a bit cleaner, we can maybe pass the new version as
`PYTHON_VERSION` env variable? And then we can leave the handling of `PYTHON`
here as is.
(I assume we can just remove that `PYTHON` env variable entirely, and just
use the default `python3` hardcoded, but lets leave that for another issue)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
