bkietz commented on code in PR #582:
URL: https://github.com/apache/arrow-nanoarrow/pull/582#discussion_r1714271821
##########
src/nanoarrow/ipc/files_test.cc:
##########
@@ -250,20 +250,33 @@ class TestFile {
// Read the same file with Arrow C++
auto maybe_table_arrow =
ReadTable(io::ReadableFile::Open(path_builder.str()));
- FAIL_RESULT_NOT_OK(maybe_table_arrow);
-
- AssertEqualsTable(std::move(schema), std::move(arrays),
- maybe_table_arrow.ValueUnsafe());
+ {
+ SCOPED_TRACE("Read the same file with Arrow C++");
+ FAIL_RESULT_NOT_OK(maybe_table_arrow);
+ AssertEqualsTable(std::move(schema), std::move(arrays),
+ maybe_table_arrow.ValueUnsafe());
+ }
- // Read the roundtripped buffer using nanoarrow
nanoarrow::UniqueSchema roundtripped_schema;
std::vector<nanoarrow::UniqueArray> roundtripped_arrays;
- ASSERT_EQ(ReadArrowArrayStreamIPC(dir_prefix, roundtripped_schema.get(),
- &roundtripped_arrays, &error),
- NANOARROW_OK);
+ {
+ SCOPED_TRACE("Read the roundtripped buffer using nanoarrow");
+ ASSERT_EQ(ReadArrowArrayStreamIPC(dir_prefix, roundtripped_schema.get(),
+ &roundtripped_arrays, &error),
Review Comment:
I think you're right. FWIW after reading from roundtripped instead of the
file the tests still pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
