birschick-bq commented on code in PR #2018:
URL: https://github.com/apache/arrow-adbc/pull/2018#discussion_r1714146757
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2Connection.cs:
##########
@@ -17,31 +17,33 @@
using System;
using System.Collections.Generic;
-using System.Diagnostics;
+using System.Net.Http.Headers;
+using System.Text;
using System.Threading;
using System.Threading.Tasks;
+using Apache.Arrow.Adbc.Drivers.Apache.Spark;
using Apache.Arrow.Ipc;
using Apache.Hive.Service.Rpc.Thrift;
using Thrift.Protocol;
using Thrift.Transport;
namespace Apache.Arrow.Adbc.Drivers.Apache.Hive2
{
- public abstract class HiveServer2Connection : AdbcConnection
+ internal abstract class HiveServer2Connection : AdbcConnection
{
- const string userAgent = "AdbcExperimental/0.0";
+ internal const long BatchSizeDefault = 50000;
+ internal const int PollTimeMillisecondsDefault = 500;
+ private const string userAgent = "AdbcExperimental/0.0";
protected TOperationHandle? operationHandle;
- protected readonly IReadOnlyDictionary<string, string> properties;
- internal TTransport? transport;
- internal TCLIService.Client? client;
- internal TSessionHandle? sessionHandle;
+ internal TTransport? _transport;
+ private TCLIService.Client? _client;
Review Comment:
Update for naming convention
##########
csharp/src/Drivers/Apache/Impala/ImpalaStatement.cs:
##########
@@ -40,70 +32,12 @@ public override object GetValue(IArrowArray arrowArray, int
index)
throw new NotSupportedException();
}
- protected override IArrowArrayStream NewReader<T>(T statement, Schema
schema) => new HiveServer2Reader(statement, schema);
-
/// <summary>
/// Provides the constant string key values to the <see
cref="AdbcStatement.SetOption(string, string)" /> method.
/// </summary>
public new sealed class Options : HiveServer2Statement.Options
{
// options specific to Impala go here
}
-
- class HiveServer2Reader : IArrowArrayStream
Review Comment:
Moved to separate file.
##########
csharp/test/Apache.Arrow.Adbc.Tests/TestEnvironment.cs:
##########
@@ -0,0 +1,74 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one or more
+* contributor license agreements. See the NOTICE file distributed with
+* this work for additional information regarding copyright ownership.
+* The ASF licenses this file to You under the Apache License, Version 2.0
+* (the "License"); you may not use this file except in compliance with
+* the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+
+using System;
+using System.Collections.Generic;
+
+namespace Apache.Arrow.Adbc.Tests
+{
+ public abstract class TestEnvironment<TConfig> where TConfig :
TestConfiguration
Review Comment:
The motivation behind loading the environment container, as opposed to
inheritance, is that we can access different data source environments from
tests, lower in the inheritance hierarchy. This will allow us to build common
tests that can be used with different data sources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
