pitrou commented on code in PR #43621:
URL: https://github.com/apache/arrow/pull/43621#discussion_r1717094130


##########
cpp/src/arrow/ipc/generate_tensor_fuzz_corpus.cc:
##########
@@ -41,7 +41,7 @@ using ::arrow::internal::PlatformFilename;
 Result<PlatformFilename> PrepareDirectory(const std::string& dir) {
   ARROW_ASSIGN_OR_RAISE(auto dir_fn, PlatformFilename::FromString(dir));
   RETURN_NOT_OK(::arrow::internal::CreateDir(dir_fn));
-  return std::move(dir_fn);

Review Comment:
   In #41025 the cast is from `std::unique_ptr` to `Result<std::shared_ptr>`, 
which is more complex (there are two cascaded casts).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to