felipecrv commented on issue #43687:
URL: https://github.com/apache/arrow/issues/43687#issuecomment-2289387315
> This make sense to me. My concern is should we change like
>
> ```diff
> void AddMinMaxAvx512AggKernels(ScalarAggregateFunction* func) {
> - AddMinMaxKernels(MinMaxInitAvx512, BaseBinaryTypes(), func,
SimdLevel::AVX2);
> + AddMinMaxKernels(MinMaxInitAvx512, BaseBinaryTypes(), func,
SimdLevel::AVX512);
> ```
>
> Or this is just intended?
No. Some places in the codebase do this, but it's a mistake: it only
generates unnecessary template instances. The SIMD level parameter should be
the smallest level that the kernel requires.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
