alamb commented on pull request #9624: URL: https://github.com/apache/arrow/pull/9624#issuecomment-791735382
> fwiw, I think that there is a different way of approaching this. Thank you @jorgecarleitao -- I like that proposal a lot and I have filed it as https://issues.apache.org/jira/browse/ARROW-11882 I am going to merge this PR in now because: 1. It doesn't fundamentally change the approach (e.g. it is just following the existing pattern) 2. It makes the code better (no more `panic!`) and includes new test coverage I think we can improve the code further in a follow on PR. Thanks again @ericwburden -- thank you, for what I think is your first contribution to Arrow ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
