pitrou commented on PR #7871: URL: https://github.com/apache/arrow/pull/7871#issuecomment-2291604601
> I understand that, but if no specialization exists for different SIMD levels, we don't need more than the SimdLevel::NONE variation of the kernel. The source code is usually the same for all variations, but the _generated_ code (which matters for ODR) varies thanks to different compiler options. https://github.com/apache/arrow/blob/8b634ad2998b6a670cc7d4d3ef0e43dea3b7aca1/cpp/src/arrow/CMakeLists.txt#L353-L359 > There is no need to populate the kernel array for `SimdLevel::AVX2` or `AVX512` if we are not performing any sort of runtime dispatching based on runtime CPU capability checks. We do: https://github.com/apache/arrow/blob/8b634ad2998b6a670cc7d4d3ef0e43dea3b7aca1/cpp/src/arrow/compute/function.cc#L133-L150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
