joellubi commented on code in PR #43679:
URL: https://github.com/apache/arrow/pull/43679#discussion_r1718785971
##########
go/parquet/metadata/app_version.go:
##########
@@ -164,7 +164,7 @@ func (v AppVersion) HasCorrectStatistics(coltype
parquet.Type, logicalType schem
// parquet-cpp-arrow version 4.0.0 fixed Decimal comparisons for
creating min/max stats
// parquet-cpp also becomes parquet-cpp-arrow as of version 4.0.0
if v.App == "parquet-cpp" || (v.App == "parquet-cpp-arrow" &&
v.LessThan(parquet1655FixedVersion)) {
- if _, ok := logicalType.(*schema.DecimalLogicalType); ok &&
coltype == parquet.Types.FixedLenByteArray {
+ if _, ok := logicalType.(schema.DecimalLogicalType); ok &&
coltype == parquet.Types.FixedLenByteArray {
Review Comment:
Some implementations of `LogicalType` were using value receivers and others
were using pointer receivers, which made it fairly inconsistent and error-prone
to work with them. Changing them all to use the same convention felt easier to
work with, and since none of the interface methods mutate the struct (i.e.
data-only) I went with a value receiver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
