alamb opened a new pull request, #6259:
URL: https://github.com/apache/arrow-rs/pull/6259

   # Which issue does this PR close?
   
   
   # Rationale for this change
   
   in https://github.com/apache/arrow-rs/pull/6216 from @Michael-J-Ward most of 
the methods on `Statistics` where deprecated and replaced with `_opt` variants
   
    For example `Statistics::null_count` is now deprecated and replaced with 
`Statistics::null_count_opt`
   
    However, for whatever reason `Statistics::distinct_count` already returned 
an Option and thus `Statistics::distinct_count_opt` was not added
   
   This is now a papercut in my opinion as the API is not consistent. Access to 
`distinct_count` should be via `distinct_count_opt` as well
   
   
   
   
   # What changes are included in this PR?
   * Add `Statistics::distinct_count_opt` and deprecate 
`Statistics::distinct_count`
   
   
   # Are there any user-facing changes?
   * deprecated method
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to