alamb commented on code in PR #6254:
URL: https://github.com/apache/arrow-rs/pull/6254#discussion_r1719011981
##########
arrow-flight/src/sql/client.rs:
##########
@@ -110,6 +110,11 @@ impl FlightSqlServiceClient<Channel> {
self.token = None;
}
+ /// Share the bearer token with potentially different `DoGet` clients
+ pub fn token(&self) -> &Option<String> {
+ &self.token
+ }
Review Comment:
I think a more "ideomatic" API would return an Option, like:
```suggestion
pub fn token(&self) -> Option<&String> {
self.token.as_ref()
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
