felipecrv commented on PR #43720: URL: https://github.com/apache/arrow/pull/43720#issuecomment-2292485578
> Could you add `internal` to file name like `aggregate_basic_common_internal.h`? See also: > > https://github.com/apache/arrow/blob/2767dc55cb41377af6895141f717475d73b2892d/cpp/cmake_modules/BuildUtils.cmake#L956-L958 I need to end it with `-inl.h` to follow the pattern found in many C++ codebases [1]. I can rename it to `aggregate_basic_internal-inl.h`. [1] https://github.com/facebook/folly/blob/main/folly/channels/ChannelProcessor-inl.h -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
