XiangpengHao commented on code in PR #6231:
URL: https://github.com/apache/arrow-rs/pull/6231#discussion_r1720764492
##########
arrow-string/src/like.rs:
##########
@@ -155,9 +156,27 @@ fn like_op(op: Op, lhs: &dyn Datum, rhs: &dyn Datum) ->
Result<BooleanArray, Arr
///
/// This trait helps to abstract over the different types of string arrays
/// so that we don't need to duplicate the implementation for each type.
-trait StringArrayType<'a>: ArrayAccessor<Item = &'a str> + Sized {
+pub(crate) trait StringArrayType<'a>: ArrayAccessor<Item = &'a str> + Sized {
Review Comment:
I agree. But I haven't thought about the exact functions to be included in
the trait. I only added whatever needed function when first creating the trait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
