zanmato1984 commented on code in PR #43734:
URL: https://github.com/apache/arrow/pull/43734#discussion_r1721271432
##########
cpp/src/arrow/compute/row/row_test.cc:
##########
@@ -156,7 +156,7 @@ TEST(RowTableOffsetOverflow, LARGE_MEMORY_TEST(Encode)) {
auto value, ::arrow::gen::Constant(
std::make_shared<BinaryScalar>(std::string(length_per_binary, 'X')))
->Generate(1));
- values.push_back(std::move(value));
Review Comment:
Why bother change this place?
##########
cpp/src/arrow/compute/kernels/CMakeLists.txt:
##########
@@ -137,4 +137,5 @@ add_arrow_compute_test(aggregate_test
# ----------------------------------------------------------------------
# Utilities
-add_arrow_compute_test(kernel_utility_test SOURCES codegen_internal_test.cc)
+add_arrow_compute_test(kernel_utility_test SOURCES codegen_internal_test.cc
Review Comment:
It seems weird to add row encoder test as part of the kernel utility suite.
If you do a search, you can find that row encoder is not referenced in
`compute/kernels` directory at all. (The only call sites are in
`compute/row/grouper.cc` and `acero/hash_join*.cc`.)
Maybe we should consider moving it out to `compute` directory. And we can
make this test part of `arrow-compute-internals-test`.
##########
cpp/src/arrow/compute/kernels/row_encoder_internal_test.cc:
##########
@@ -0,0 +1,65 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <gmock/gmock.h>
+#include <gtest/gtest.h>
+
+#include "arrow/compute/kernels/row_encoder_internal.h"
+#include "arrow/testing/gtest_util.h"
+#include "arrow/type.h"
+#include "arrow/type_fwd.h"
+
+namespace arrow::compute::internal {
+
+// GH-43733: Test that the key encoder can handle boolean scalar values well.
+TEST(TestKeyEncoder, BooleanScalar) {
Review Comment:
I'm sorry that I pointed you to the wrong place because I didn't realize the
`RowEncoder` staff (used for naive hash join/aggregation implementation) was
not related to the `row` stuff (used for swiss join/fast aggregation).
You did right. Here is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
