larry98 commented on PR #43256: URL: https://github.com/apache/arrow/pull/43256#issuecomment-2297414488
> I think that this needs more tests and should at least initially be simplified to avoid sorting/uniquing sets altogether. Initially winnowing of value sets should be accomplished by filtering with the guarantee. > > After this PR merges with a complete set of correctness tests, a follow up PR can add the performance enhancement of slicing sorted value sets (ideally with a benchmark to demonstrate the improvement for large value sets/many guarantees/...) I opened https://github.com/apache/arrow/pull/43761 which contains the basic implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
