jorisvandenbossche commented on code in PR #41580:
URL: https://github.com/apache/arrow/pull/41580#discussion_r1722954541
##########
python/pyarrow/tests/parquet/conftest.py:
##########
@@ -25,6 +28,15 @@ def datadir(base_datadir):
return base_datadir / 'parquet'
[email protected](scope='module')
+def parquet_test_datadir():
+ result = os.environ.get('PARQUET_TEST_DATA')
+ if not result:
+ raise RuntimeError('Please point the PARQUET_TEST_DATA environment '
+ 'variable to the test data directory')
+ return pathlib.Path(result)
Review Comment:
This is the first time we introduce a pyarrow test that requires this to be
set up. Do we want to require that strictly, or should we skip the test if the
env variable is not set?
In any case this caused a failure in one of the nightly crossbow builds
which doesn't have this env variable set (python-emscriptem,
https://github.com/ursacomputing/crossbow/actions/runs/10463078918/job/28974494645#step:7:15654)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
