jorisvandenbossche commented on code in PR #43617:
URL: https://github.com/apache/arrow/pull/43617#discussion_r1723491912
##########
docs/source/developers/python.rst:
##########
@@ -398,7 +398,7 @@ Now, build pyarrow:
$ pushd arrow/python
$ export PYARROW_PARALLEL=4
- $ python setup.py build_ext --inplace
+ $ python -m pip install -e .
Review Comment:
```suggestion
$ python -m pip install -e . --no-build-isolation --no-deps -v
```
Those additional flags make it more similar to what we did before. It's
probably debatable whether those should be added (disabling build isolation and
installing deps), but since in this tutorial we have set up all build
dependencies in advance, not doing that gives unnecessary pip overhead.
(this is also the command that I use locally, although for quick rebuilds I
still use `python setup.py build_ext --inplace`)
##########
docs/source/developers/python.rst:
##########
@@ -548,7 +545,7 @@ Now, we can build pyarrow:
$ pushd arrow\python
$ set CONDA_DLL_SEARCH_MODIFICATION_ENABLE=1
- $ python setup.py build_ext --inplace
+ $ python pip install -e .
Review Comment:
```suggestion
$ python pip install -e . --no-build-isolation --no-deps -v
```
(depending on what is done above)
##########
docs/source/developers/python.rst:
##########
@@ -427,12 +427,9 @@ libraries), one can set ``--bundle-arrow-cpp``:
.. code-block::
$ pip install wheel # if not installed
- $ python setup.py build_ext --build-type=$ARROW_BUILD_TYPE \
- --bundle-arrow-cpp bdist_wheel
-
-.. note::
- To install an editable PyArrow build run ``pip install -e .
--no-build-isolation``
- in the ``arrow/python`` directory.
+ $ python -m pip wheel . \
Review Comment:
```suggestion
$ python -m build . \
```
Using https://build.pypa.io/en/stable/ might be the recommended way nowadays
to build a wheel?
When using that, it might need `--config-setting` instead of
`--global-option` (but haven't verified this works the same)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
