xinlifoobar commented on PR #6231:
URL: https://github.com/apache/arrow-rs/pull/6231#issuecomment-2301291577
> > 🤔 the benchmarks fail now for me like
> > ```
> >
> > Benchmarking eq scalar StringViewArray: Warming up for 3.0000 sthread
'main' panicked at arrow/benches/comparison_kernels.rs:196:50:
> > called `Result::unwrap()` on an `Err` value:
InvalidArgumentError("Invalid comparison operation: Utf8 == Utf8View")
> > note: run with `RUST_BACKTRACE=1` environment variable to display a
backtrace
> >
> > error: bench failed, to rerun pass `-p arrow --bench comparison_kernels`
> > ```
>
> This issue could be repro on the `master` branch... I looked into the
history the benchmark shouldn't work at the time it was checked in. Comment out
this bench and everything works then...
>
>
https://github.com/alamb/arrow-rs/blob/8941cbf5325b380bf70ea1ee5950f570a102c873/arrow-ord/src/cmp.rs#L235-L239
This would be a more complex fix than expected. The following functions,
including `appy`, `apply_op*` are expected the lhs and rhs are of the same data
type. How about doing conventions beforehead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
