kou commented on PR #43705:
URL: https://github.com/apache/arrow/pull/43705#issuecomment-2301596345

   > Alternatively if we want to keep statistics out of ArrayData, Datum will 
need to be modified to include statistics as well. That might be less work than 
ensuring ArrayData is never mutated and left with invalid statistics.
   
   I didn't think about the approach. I'll consider the approach.
   
   > A struct array's statistics would contain no information about any 
children if it were only attached to the StructArray.
   
   Ah, you're right. I missed it.
   
   `StructArray::field()` creates a child field from `ArrowData` lazy: 
https://github.com/apache/arrow/blob/9fc03015463a8f1cb616b088342b104fbc767a0c/cpp/src/arrow/array/array_nested.cc#L1088
   So we can't attach `ArrowStatistics` to children of `StructArray`.
   (If we want to do it, we need to attach children's `ArrowStatistics` to 
`StructArray`.)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to