alamb commented on code in PR #6284:
URL: https://github.com/apache/arrow-rs/pull/6284#discussion_r1725453967
##########
arrow/benches/comparison_kernels.rs:
##########
@@ -192,8 +192,20 @@ fn add_benchmark(c: &mut Criterion) {
})
});
- c.bench_function("eq scalar StringViewArray", |b| {
- b.iter(|| eq(&scalar, &string_view_left).unwrap())
Review Comment:
the panic came from this line which passes a scalar of type `StringArray` to
a comparison kernel with `StringViewArray` -- the fix was to make the
appropriate scalar type with `let string_view_scalar =
StringViewArray::new_scalar("xxxx");`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
