tustvold commented on PR #6281: URL: https://github.com/apache/arrow-rs/pull/6281#issuecomment-2305187753
I'd echo Andrew's points and perhaps expand that this crate historically made a lot more use of unsafe. A significant effort over the last few years has been reducing this. This has not only yielded easier to maintain code, but in some cases also faster, as the compiler can better understand what is going on. An example of where unsafe is easy to justify is the arithmetic kernels where the bounds checks otherwise break autovectorisation leading to a 8x performance hit. But if we're talking 5%, I'd probably think it isn't worth it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
