tustvold commented on code in PR #6290:
URL: https://github.com/apache/arrow-rs/pull/6290#discussion_r1728520184
##########
parquet/Cargo.toml:
##########
@@ -96,7 +96,7 @@ zstd-sys = { version = ">=2.0.0, <2.0.14", default-features =
false }
all-features = true
[features]
-default = ["arrow", "snap", "brotli", "flate2", "lz4", "zstd", "base64"]
+default = ["arrow", "snap", "brotli", "flate2", "lz4", "zstd", "base64", "crc"]
Review Comment:
I don't think we should enable this by default
##########
parquet/src/errors.rs:
##########
@@ -43,6 +43,7 @@ pub enum ParquetError {
/// Returned when reading into arrow or writing from arrow.
ArrowError(String),
IndexOutOfBound(usize, usize),
+ Crc32Mismatch,
Review Comment:
Unfortunately this would be a breaking change, perhaps we could reuse one of
the existing variants
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
