tustvold commented on code in PR #6291:
URL: https://github.com/apache/arrow-rs/pull/6291#discussion_r1728662441
##########
arrow-array/src/builder/generic_bytes_view_builder.rs:
##########
@@ -205,6 +205,19 @@ impl<T: ByteViewType + ?Sized> GenericByteViewBuilder<T> {
self.null_buffer_builder.append_non_null();
}
+ /// Append the given `u128` as a view
+ ///
+ /// # Safety
+ /// (1) The block of the given view must have been added
+ /// (2) The range `offset...offset+length` of the given view
+ /// must be within the bounds of the block
+ /// (3) The data in the block must be valid type `T`
+ /// (4) The view must be not null
+ pub unsafe fn append_view_u128_unchecked(&mut self, view: u128) {
Review Comment:
https://docs.rs/arrow-array/latest/arrow_array/array/struct.GenericByteViewArray.html#method.new_unchecked
and
https://docs.rs/arrow-array/latest/arrow_array/array/struct.GenericByteViewArray.html#method.into_parts
are the relevant methods FWIW
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
