alamb commented on code in PR #6295:
URL: https://github.com/apache/arrow-rs/pull/6295#discussion_r1729951766
##########
parquet/src/file/statistics.rs:
##########
@@ -186,14 +186,18 @@ pub fn from_thrift(
// INT96 statistics may not be correct, because comparison
is signed
// byte-wise, not actual timestamps. It is recommended to
ignore
// min/max statistics for INT96 columns.
- let min = min.map(|data| {
+ let min = if let Some(data) = min {
Review Comment:
If we make invalid statistics return an error I think it will mean the
reader will not be able to read any data from the file
What do you think about ignoring the error. `.ok()` style instead here --
that way the statistics would come in as `None` but the file could still be read
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
