jorisvandenbossche commented on code in PR #43795:
URL: https://github.com/apache/arrow/pull/43795#discussion_r1730986657
##########
cpp/src/arrow/chunked_array.cc:
##########
@@ -48,16 +48,22 @@ ChunkedArray::ChunkedArray(ArrayVector chunks,
std::shared_ptr<DataType> type)
type_(std::move(type)),
length_(0),
null_count_(0),
+ device_type_(DeviceAllocationType::kCPU),
Review Comment:
We could move this "caching" to the Python side for now (if we don't want to
do this in C++, which I think is certainly fine), or otherwise wait on your PR
https://github.com/apache/arrow/pull/43542 to land.
(and we should maybe still consider caching the DeviceAllocationTypeSet
result? It might be cheap to calculcate in C++, but we still call this before
_every_ call of many methods on the python object)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
