raulcd commented on code in PR #43671: URL: https://github.com/apache/arrow/pull/43671#discussion_r1731317705
########## python/CMakeLists.txt: ########## @@ -21,6 +21,8 @@ cmake_minimum_required(VERSION 3.16) project(pyarrow) +set(CMAKE_NO_SYSTEM_FROM_IMPORTED ON) Review Comment: > > Can we use the `SYSTEM` target property https://cmake.org/cmake/help/latest/prop_tgt/SYSTEM.html instead of this to limit the impact? > > What my change is the exact opposite though. It's signifying to not use `SYSTEM` anywhere, which I guess is what `FindPython` does. Unless I am mistaken @kou is suggesting, to set `SYSTEM` to `FALSE` for Python but leave it as is for the rest of dependencies instead of changing it globally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
