xinlifoobar commented on code in PR #6306:
URL: https://github.com/apache/arrow-rs/pull/6306#discussion_r1732795874
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -317,8 +317,11 @@ impl<T: ByteViewType + ?Sized> GenericByteViewArray<T> {
})
}
- /// Returns an iterator over the prefix bytes of this array with respect
to the prefix length.
- /// If the prefix length is larger than the string length, it will return
the empty slice.
+ /// Returns an iterator over the first `prefix_len` bytes of each array
+ /// element, including null values.
+ ///
+ /// If `prefix_len` is larger than the element's length, the iterator will
Review Comment:
Thanks for the suggestions! @tustvold.
I created a new PR #6312 to put this discussion. I did this in the early
version but didn't see performance gains like this time - it did well for
inline values. We might do a combination based on the bench result, e.g., null
masks for prefix_iter and slice for suffix_iter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
