soxofaan commented on code in PR #43818:
URL: https://github.com/apache/arrow/pull/43818#discussion_r1733165709
##########
python/pyarrow/parquet/core.py:
##########
@@ -2081,11 +2081,11 @@ def file_visitor(written_file):
the entire directory will be deleted. This allows you to overwrite
old partitions completely.
**kwargs : dict,
- Used as additional kwargs for :func:`pyarrow.dataset.write_dataset`
+ Used as additional kwargs for :py:func:`pyarrow.dataset.write_dataset`
Review Comment:
`py` is indeed the default domain (unless
[configured](https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-primary_domain)
otherwise). I have however the habit to keep it explicit, mainly because I
feel it's better [documented in sphinx
docs](https://www.sphinx-doc.org/en/master/usage/domains/python.html#python-xref-roles)
and easier to google for newcomers I guess.
But again, I'm happy to drop it again to better align with guidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
