felipecrv commented on code in PR #43795:
URL: https://github.com/apache/arrow/pull/43795#discussion_r1733349179
##########
python/pyarrow/tests/test_table.py:
##########
@@ -3357,3 +3357,179 @@ def test_invalid_non_join_column():
with pytest.raises(pa.lib.ArrowInvalid) as excinfo:
t2.join(t1, 'id', join_type='inner')
assert exp_error_msg in str(excinfo.value)
+
+
[email protected]
+def cuda_context():
+ cuda = pytest.importorskip("pyarrow.cuda")
+ return cuda.Context(0)
+
+
[email protected]
+def schema():
+ return pa.schema([pa.field('c0', pa.int16()), pa.field('c1', pa.int32())])
+
+
[email protected]
+def cpu_arrays():
+ return [pa.array([1, 2, 3, 4, 5], pa.int32()),
+ pa.array([-10, -5, 0, None, 10], pa.int32())]
+
+
[email protected]
+def cuda_arrays(cuda_context, cpu_arrays):
+ return [arr.copy_to(cuda_context.memory_manager) for arr in cpu_arrays]
+
+
[email protected]
+def cpu_chunked_array(cpu_arrays):
+ chunked_array = pa.chunked_array(cpu_arrays)
+ assert chunked_array.is_cpu() is True
+ return chunked_array
+
+
[email protected]
+def cuda_chunked_array(cuda_arrays):
+ chunked_array = pa.chunked_array(cuda_arrays)
+ assert chunked_array.is_cpu() is False
+ return chunked_array
+
+
[email protected]
+def cpu_and_cuda_chunked_array(cpu_arrays, cuda_arrays):
+ chunked_array = pa.chunked_array(cpu_arrays + cuda_arrays)
+ assert chunked_array.is_cpu() is False
+ return chunked_array
+
+
+def test_chunked_array_non_cpu(cuda_context, cpu_chunked_array,
cuda_chunked_array,
+ cpu_and_cuda_chunked_array):
+ # type test
+ assert cuda_chunked_array.type == cpu_chunked_array.type
+
+ # length() test
+ assert cuda_chunked_array.length() == cpu_chunked_array.length()
+
+ # str() test
+ assert str(cuda_chunked_array) == str(cpu_chunked_array)
+
+ # repr() test
+ assert str(cuda_chunked_array) in repr(cuda_chunked_array)
+
+ # validate() test
+ cuda_chunked_array.validate()
+ with pytest.raises(NotImplementedError):
+ cuda_chunked_array.validate(full=True)
+
+ # null_count test
+ assert cuda_chunked_array.null_count == cpu_chunked_array.null_count
Review Comment:
It's important to create an array with nulls for these tests. Because
`null_count` can return early if no validity buffer is set. The `drop_null`
tests on `array.pxi` only crashed when I changed the test example to an array
with nulls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
