zeroshade commented on code in PR #2106:
URL: https://github.com/apache/arrow-adbc/pull/2106#discussion_r1735099267
##########
go/adbc/driver/snowflake/bulk_ingestion.go:
##########
@@ -595,3 +678,39 @@ func (bp *bufferPool) PutBuffer(buf *bytes.Buffer) {
buf.Reset()
bp.Pool.Put(buf)
}
+
+type fileSet struct {
+ mu sync.RWMutex
+ data map[string]struct{}
+}
Review Comment:
is this better / worse than just using `sync.Map`?
`sync.Map` is generally best for primarily append workflows with few
delete/removes, but for our workflows here I doubt it would make too much of a
difference other than avoiding us having to maintain this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
