WillAyd commented on code in PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#discussion_r1735479958
##########
meson.build:
##########
@@ -35,6 +35,12 @@ project(
# add_project_arguments(['-fvisibility=hidden'], language: 'cpp')
# endif
+cpp = meson.get_compiler('cpp')
+add_project_arguments(
+ cpp.get_supported_arguments(['-Wno-misleading-indentation']),
Review Comment:
This warning was generated by the flatcc_generated header. There are a ton
of these.
Perhaps there is a way to have it fixed on generation, but for now figure
fine to ignore
##########
meson.build:
##########
@@ -161,7 +167,8 @@ if get_option('tests')
# Similarly code coverage has a built in option users should use instead
# https://mesonbuild.com/Unit-tests.html#coverage
- arrow_dep = dependency('arrow')
+ # The system include suppresses compilation warnings from Arrow
+ arrow_dep = dependency('arrow', include_type: 'system')
Review Comment:
Rather than chasing down the Arrow failures, I figured we can just ignore
them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
