zanmato1984 commented on code in PR #43871:
URL: https://github.com/apache/arrow/pull/43871#discussion_r1735990622
##########
cpp/src/arrow/acero/hash_join_benchmark.cc:
##########
@@ -104,7 +104,7 @@ class JoinBenchmark {
key_cmp.push_back(JoinKeyCmp::EQ);
}
- for (size_t i = 0; i < settings.build_payload_types.size(); i++) {
+ for (size_t i = 0; i < settings.probe_payload_types.size(); i++) {
Review Comment:
It is supposed to. But I didn't review the complete benchmarks that are
utilizing this piece of code. There might be a chance that all benchmarks are
using the same number of payload columns thus no result change.
Is there anything we should be preparing for a potential benchmark result
change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
